Repository navigation
Version Packages - #13
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
commandmenu@0.6.0
Minor Changes
4af0944: Rework the hook around a single ordered item list and add ARIA wiring.
Breaking:
itemProps(id,role,aria-disabled,onClick,onMouseDown,onPointerMove) instead of top-levelonClick/onPointerMove. Spread it onto the item element.selectionis replaced byselectedId. Scrolling needs no ref wiring from you:listPropsnow carries aref, which the hook uses.Group<T>now accepts either an item type or a config array type.groups, async results are appended to the flat list instead of replacing it with a single group.PreparedItemkeepsdisabledso you can style it.menuProps.onKeyUpis always a function and calls your latestonKeyUp.isAsyncLoadingis removed, andAsyncResultsGroupno longer takesisLoading. Both only handed back the value you passed in; keep the loading state in your own component.Fixes:
scroll-marginandscroll-padding.onSearchChange("")fires when the query is reset after a selection.onKeyDownruns before shortcut matching, so it can intercept.onKeyDown,onKeyUpandonSearchChangeno longer rebuild the list.menuPropsandlistPropskeep their identity across renders.listno longer rebuilds whenasyncResultsGroupis recreated around the sameitemsarray, or around a fresh empty one.isGroupListis no longer fooled by items that carry their ownitemsfield.PreparedItemdistributes over unions, so discriminated item types keep each variant's fields.as constconfigs keep the optionalConfigfields readable.as constconfig and typedgroups.Performance:
config/groupsrather than per keystroke.Added:
useCommandMenu<T>is generic over the item type. Extra fields on items are preserved inPreparedItem<T>.searchPropscarries combobox ARIA attributes,listPropscarriesrole="listbox", itsidand aref.sideEffects: falseand per-format type entries inexports.