Preserve persistent sessions on WebSocket close - #573
Merged
embhorn merged 1 commit intoAug 13, 2026
Conversation
aidangarske
commented
Aug 12, 2026
aidangarske
commented
Member
There was a problem hiding this comment.
Pull request overview
Updates the embedded broker’s libwebsockets close-handling so that clients with persistent sessions keep their session state when the underlying WebSocket is closed, aligning WS teardown behavior with the broker’s existing session-persistence model.
Changes:
- On
LWS_CALLBACK_CLOSED, publish the client’s Will and then either remove or orphan subscriptions based on session persistence. - Add a forward declaration for
BrokerSubs_OrphanClientfor use in the WS callback.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aidangarske
force-pushed
the
fix/websocket-persistent-session
branch
from
August 12, 2026 19:43
081ed1b to
faf11dc
Compare
embhorn
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.