Preserve nonblocking enhanced authentication state - #574
Merged
embhorn merged 1 commit intoAug 13, 2026
Conversation
aidangarske
commented
Aug 12, 2026
aidangarske
commented
Member
There was a problem hiding this comment.
Pull request overview
Updates the MQTT v5 client’s enhanced-authentication flow to preserve state across nonblocking/multi-threaded retries, avoiding loss of in-flight AUTH progress during MqttClient_Connect.
Changes:
- Refactors AUTH handling into a reusable internal helper (
MqttClient_AuthEx) that can operate on caller-supplied state and packet objects. - Extends
MqttClient_WaitTypeto optionally drive its state machine from an externalMqttMsgStat, enabling CONNECT-enhanced-auth to persist state across nonblocking calls. - Adds multi-threaded coordination around reuse of
client->packetAckwhile automatic AUTH is pending.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
embhorn
requested changes
Aug 12, 2026
embhorn
left a comment
embhorn
left a comment
Member
There was a problem hiding this comment.
Would like to see a test case
embhorn
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.