Repository navigation
Negotiate the SPDM version before GET_PUBK - #39
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to negotiate the SPDM version before public-key discovery.
No open issues 🎉
What changed in this PR
Ensures TCG public-key discovery negotiates the SPDM version before sending GET_PUBK, addressing Nuvoton NPCT75x rejection of requests sent before negotiation.
Changes:
- Adds version negotiation for fresh contexts and returns negotiation errors without sending
GET_PUBK. - Adds tests for request ordering, reuse of the negotiated version, and successful retry after negotiation failure.
| File | Description |
|---|---|
test/unit_test.c |
Updates the mock to enforce negotiation ordering and adds success and failure/retry tests. |
src/spdm_tcg.c |
Negotiates the version before GET_PUBK when the context is in its initial state. |
Review effort: Balanced
dgarske
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs wolfSSL/wolfTPM#670