Skip to content

More various fixes (F-*)#98

Merged
danielinux merged 1 commit intowolfSSL:masterfrom
gasbytes:2026-04-8-fixes
Apr 9, 2026
Merged

More various fixes (F-*)#98
danielinux merged 1 commit intowolfSSL:masterfrom
gasbytes:2026-04-8-fixes

Conversation

@gasbytes
Copy link
Copy Markdown
Contributor

@gasbytes gasbytes commented Apr 8, 2026

  • fix listen socket descrution on SYN_RCVD ctrl-RTO expirty:
    revert to TCP_LISTEN instead of close_socket()
  • add missing esp encapsulation to icmp tx path in wolfip_poll()
  • add alignment guard to tcp ts option fit-check in tcp_send_syn(), matching ws and sack patterns
  • add missing esp encapsulation to icmp echo reply path in icmp_input()
  • add missing esp encapsulation to icmp port unreachable pathh in wolfip_send_port_unreachable()
  • add rfc 9293 compliant rst handling for tcp syn__sent state
  • add sequence number validation of rst segments in tcp syn_rcvd state per rfc 9293
  • add source ip validation in ip_recv() to drop broadcast, multicast and zero-address packets per rfc 1122
  • validate arp request sender ip before caching to prevent cache poisoningg from spoofed sources
  • validate dhcp ack server identifier matches the server commiteed during offer phase
  • add coverage tests for icmp port unreachable suppression on broadcast/multicast source and destination
  • add coverage tests for tcp rst suppression on broadcast and multicast destination addresses
  • add coverage test for dhcp renewing to rebinding state transition at rebind deadline boundary
  • add coverage test for icmp echo reply suppression on multicast destination addresses
  • validate arp * fields in arp_recv and update existing tests to set them correctly
  • Use wc_ForceZero for ESP SA key material clearing and update CI workflows to build wolfSSL from source with --enable-md5
  • add missing esp encapsulation to icmp ttl exceeded path in wolfip_send_ttl_exceeded()
  • send rst in response to syn-ack with invalid ack in syn_sent state per rfc 9293
  • send rst in response to aunnaccetable ack in syn_rcvd state per rfc 9293
  • drop segments without ack flag in synchronized tcp states per rfc 9293
  • drop ip packets with source routine options (lsrr/ssrr) per rfc 7126

@gasbytes gasbytes marked this pull request as ready for review April 8, 2026 18:15
@gasbytes gasbytes self-assigned this Apr 9, 2026
- fix listen socket descrution on SYN_RCVD ctrl-RTO expirty:
revert to TCP_LISTEN instead of close_socket()
- add missing esp encapsulation to icmp tx path in wolfip_poll()
- add alignment guard to tcp ts option fit-check in tcp_send_syn(), matching ws and sack patterns
- add missing esp encapsulation to icmp echo reply path in icmp_input()
- add missing esp encapsulation to icmp port unreachable pathh in wolfip_send_port_unreachable()
- add rfc 9293 compliant rst handling for tcp syn__sent state
- add sequence number validation of rst segments in tcp syn_rcvd state per rfc 9293
- add source ip  validation in ip_recv() to drop broadcast, multicast and zero-address packets per rfc 1122
- validate arp request sender ip before caching to prevent cache poisoningg from spoofed sources
- validate dhcp ack server identifier matches the server commiteed during offer phase
- add coverage tests for icmp port unreachable suppression on broadcast/multicast source and destination
- add coverage tests for tcp rst suppression on broadcast and multicast destination addresses
- add coverage test for dhcp renewing to rebinding state transition at rebind deadline boundary
- add coverage test for icmp echo reply suppression on multicast destination addresses
- validate arp * fields in arp_recv and update existing tests to set them correctly
- Use wc_ForceZero for ESP SA key material clearing and update CI workflows to build wolfSSL from source with --enable-md5
- add missing esp encapsulation to icmp ttl exceeded path in wolfip_send_ttl_exceeded()
- send rst in response to syn-ack with invalid ack in syn_sent state per rfc 9293
- send rst in response to aunnaccetable ack in syn_rcvd state per rfc 9293
- drop segments without ack flag in synchronized tcp states per rfc 9293
- drop ip packets with source routine options (lsrr/ssrr) per rfc 7126
@gasbytes gasbytes requested a review from danielinux April 9, 2026 12:21
@gasbytes gasbytes assigned danielinux and unassigned gasbytes Apr 9, 2026
@danielinux danielinux merged commit 9daef19 into wolfSSL:master Apr 9, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants