Add PermitRootLogin prohibit-password and forced-commands-only - #1111
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
9e1bbd9 to
71e1e28
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
71e1e28 to
9937fff
Compare
|
Rebased onto latest master, which added a72b944 (roots PermitRootLogin on uid 0). Extracted into a shared IsRootUser() and pointed my prohibit-password / forced-commands-only checks at it too. Also dropped my fake-crypt timing mitigation for invalid users, will make a dedicated PR for the timing oracle mitigations. |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
ebb3394 to
9cc97ed
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
9cc97ed to
c05b9c4
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
c05b9c4 to
ad3840e
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
ad3840e to
3c3933c
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
3c3933c to
58f7070
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1111
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
58f7070 to
80bfe96
Compare
4 participants
Expanded PermitRootLogin configuration to fully support OpenSSH settings prohibit-password (including legacy without-password) and forced-commands-only.
Added additional test coverage for this new feature.