Fix the output flags - #897
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects wolfSSH_DoModes() so that terminal output mode opcodes update termios.c_oflag (output flags) instead of incorrectly updating termios.c_lflag (local flags), aligning behavior with RFC terminal mode semantics.
Changes:
- Fix output-mode opcodes (
WOLFSSH_OPOST,WOLFSSH_OLCUC,WOLFSSH_ONLCR,WOLFSSH_ONOCR,WOLFSSH_ONLRET) to apply toterm.c_oflag. - Correct the preprocessor guard typo for
ONLCR(#ifdef ONLCR), ensuring theONLCRhandling is compiled when available. - Update the (intentionally disabled)
OCRNLline to referenceterm.c_oflagfor consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original wolfSSH_DoModes() changes the local modes instead of output modes unintentionally.
This PR fixes the target flags so that output flags would be changed when requested.