Add additional regress test for DoKexDhReply - #923
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a missing regression scenario for DoKexDhReply() where the client’s publicKeyCheckCb is present but explicitly rejects the server host key, ensuring the client fails the handshake with WS_PUBKEY_REJECTED_E.
Changes:
- Introduces a
RejectAnyServerHostKey()callback that always rejects the server host key. - Adds a new KEXDH reply regress test that sets the reject callback and asserts the client error is
WS_PUBKEY_REJECTED_E. - Hooks the new test into the existing
KEXDH_REPLY_REGRESS_KEX_ALGOtest block inmain().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a missing scenario of regress test for DoKexDhReply().
This PR adds a test that sets a publicKeyCheckCb which returns non-zero (reject), then attempts a connection. Then it verifies the client gets WS_PUBKEY_REJECTED_E.