Add integration test for wrong ECC signature scenario - #968
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new negative integration test to ensure ECC public-key authentication fails when the client presents an authorized (structurally valid) ECC public key but produces an invalid ECDSA signature, validating the expected WS_FATAL_ERROR behavior at the API boundary.
Changes:
- Added
test_pubkey_auth_ecc_bad_sig()to drive a wrong-signature path while keeping the public key authorized. - Registered the new test in
wolfSSH_AuthTest()under the existing ECC test guard.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yosuke-wolfssl
assigned
wolfSSL-Bot and
yosuke-wolfssl and unassigned
yosuke-wolfssl and
wolfSSL-Bot
ejohnstown
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test that drives DoUserAuthRequestEcc with a structurally valid ECC pubkey but a tampered signature and assert that authentication fails with WS_FATAL_ERROR at the API boundary.
Addressed by f_3876