Repository navigation
Allow UniqueList self-assignment for non-reflexive values - #65
Merged
wolph merged 1 commit intoOct 29, 2026
Merged
Conversation
Owner
|
Thank you for the fix! NaN not being equal to itself strikes again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniqueList(nan, on_duplicate='raise')[0] = nancurrently raises a duplicate error even though the same object remains in the same slot. NaN compares unequal to itself, so the equality-only check mistakes self-assignment for a duplicate elsewhere.Check identity before inequality, matching the identity shortcut used by Python containers. Tests cover both duplicate modes and positive/negative indexes; assigning the same NaN into another occupied slot still raises. The class doctest also illustrates self-assignment.
Two regressions fail before the fix; three controls pass. Full Python 3.10 and 3.12 suites: 374 passed, 5 optional timezone-data skips, 100% branch/statement coverage. Whole-project mypy, basedpyright and Pyrefly report no errors. Ruff lint and formatting of changed files, plus
git diff --check, pass. No matching open issue or PR found.AI assistance: OpenAI Codex (GPT-6). Original user request:
new 14ta koro aro(make 14 more new contributions). Diff inspection was automated; no human review or personal production usage is claimed.