Skip to content

Don't break URL just because HTTP is used without parameters.#101

Open
bigretromike wants to merge 1 commit intowoocommerce:trunkfrom
bigretromike:trunk
Open

Don't break URL just because HTTP is used without parameters.#101
bigretromike wants to merge 1 commit intowoocommerce:trunkfrom
bigretromike:trunk

Conversation

@bigretromike
Copy link

While using http connection without extra parameters url constructor add undesired "?"
example:

wcapi.get("/products?sku=test")

with http connection will become:

http://example.domain/wp-json/wc/v3/products?sku=test%3F&oauth_consumer_key=ck_xxx&oauth_timestamp=1717745432&oauth_nonce=12afaxxx&oauth_signature_method=HMAC-SHA256&oauth_signature=kxxxx

after test there is added ? then its coded with parameters (or the absense of them) as %3F which breaks api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant