Open
Conversation
jkmassel
force-pushed
the
decouple/swift-soup
branch
2 times, most recently
from
832d686 to
142b02e
Compare
jkmassel
force-pushed
the
decouple/swift-soup
branch
4 times, most recently
from
cda24fb to
b64d3ab
Compare
jkmassel
force-pushed
the
decouple/swift-soup
branch
from
b64d3ab to
f96c145
Compare
dcalhoun
reviewed
Sep 11, 2025
Member
There was a problem hiding this comment.
The intent and changes seem sound from review. Unfortunately, the implementation does not work from my testing. The cached assets are never used when inspecting network activity of the WebView. Do you experience this as well?
I tested by configuring the Demo app. I could not test with WP-iOS due to the current incompatibility with WP-iOS with the merge of #146.
| Trunk | Changes |
|---|---|
 |
 |
| } | ||
|
|
||
| public static let `default` = EditorConfigurationBuilder().build() | ||
| public static var `default` = EditorConfigurationBuilder().build() |
Member
There was a problem hiding this comment.
Why the change from let to var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moves the
Swiftsoupdependency out into its own package that can be conditionally used.Why?
The library current requires that its hosting app adopt
Swiftsoup. It's only used for a small corner of the functionality where regex might not properly parse the data we get back from the server.How?
Creates a new
AssetManifestParserpackage that can be included (or not). By default, the implementation now uses a regex-based approach, but warns that it's not recommended.Testing Instructions
I've added unit tests for both the default and new parsers that cover the parsing better than it was before.
I'd recommend testing it against a site using the assets plugin.
Accessibility Testing Instructions
n/a
Screenshots or screencast
n/a