Migrate NewDomainsSearchRepository from FluxC to wordpress-rs#22891
Migrate NewDomainsSearchRepository from FluxC to wordpress-rs#22891oguzkocer wants to merge 2 commits into
NewDomainsSearchRepository from FluxC to wordpress-rs#22891Conversation
Replace FluxC's `ProductsStore` + dispatcher-based domain suggestions with direct wordpress-rs API calls: - Fetch domain suggestions via `WpComApiClient.domains().suggestions()` - Fetch products via `WpComApiClient.products().list()` for sale pricing - Match suggestions to products by `productId` to get server-formatted `combinedSaleCostDisplay` (1:1 with trunk's behavior) - Remove `SuggestedDomainsFetcher` (FluxC dispatcher wrapper)
|
|
|
|
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
| onlyWordpressdotcom = false, // checkstyle ignore | ||
| includeWordpressdotcom = false, // checkstyle ignore |
There was a problem hiding this comment.
@jkmassel Would you prefer if we changed these parameter field names to comply with our checkstyle rules, or keep them as is — matching what the API returns?
There was a problem hiding this comment.
I think it makes a lot more sense to match the API
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22891 +/- ##
=======================================
Coverage 37.32% 37.32%
=======================================
Files 2320 2319 -1
Lines 124578 124583 +5
Branches 16926 16928 +2
=======================================
+ Hits 46498 46506 +8
+ Misses 74319 74316 -3
Partials 3761 3761 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|


Description
Replace FluxC's
ProductsStore+ dispatcher-based domain suggestions with direct wordpress-rs API calls:WpComApiClient.domains().suggestions()WpComApiClient.products().list()for sale pricingproductIdto get server-formattedcombinedSaleCostDisplay(1:1 with trunk's behavior)SuggestedDomainsFetcher(FluxC dispatcher wrapper)Testing instructions
Me > Domains > Find a domainflow before and after this change.Here are 2 recordings to showcase it:
before.webm
after.webm