You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a new screen, "Uploading Media", which is presented after the user selects photos/documents to upload. This modal is not dismissible until all uploads are completed.
Users can stop and restart the uploads on this screen. However, this may not work correctly at this time until Automattic/wordpress-rs#794 (which resolves an issue with uploading media) is merged.
This modal is not dismissible until all uploads are completed.
With the current UI/UX, the upload progress is displayed directly on the "Media" screen, which seems quite optimal: you select media for upload and are free to check out other screens, such as Reader or Stats, while it's uploading. You don't want to be stuck on a blocking modal. What is the reasoning behind making it blocking?
It can be useful to show the overall upload status somewhere below like so:
Btw, there is an existing PostMediaUploadsViewController that could be generalized, or at least some of its components could. It looks like this and it automatically observes Media items and let's you cancel/retry the uploads:
Jeremy talked about this in the meetup. The main idea is no background uploads. My understanding is that a blocking UI gives the impression that users have to wait on this screen; there might be a lower chance that they'll switch to other apps. So, the upload will be more reliable.
there is an existing PostMediaUploadsViewController that could be generalized
My recollection is that it was mentioned in the context of "syncing" posts, which we have no API for, and similar topics. Uploading media is a pretty clear scenario where you actually do want background uploads. Ideally, it would be using background URLSession so that the uploads continue even if the app is terminated.
there might be a lower chance that they'll switch to other apps. So, the upload will be more reliable.
I think it's just as likely they'll be annoyed by it and will background the app to wait until the upload finishes, which is the opposite of what you want and will not help, unless they app can handle background uploads.
the upload will be more reliable.
Are they currently unreliable? In the worst-case scenario, the app gets terminated during the upload, and it just restarts when you reopen it. Not sure how well it's implemented atm, but it's a pretty basic scenario to cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is built on top of #24655.
Description
This PR adds a new screen, "Uploading Media", which is presented after the user selects photos/documents to upload. This modal is not dismissible until all uploads are completed.
Users can stop and restart the uploads on this screen. However, this may not work correctly at this time until Automattic/wordpress-rs#794 (which resolves an issue with uploading media) is merged.
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-07.at.22.15.13.mp4
Testing instructions