[Tooling] Update release-toolkit to 14.0 by iangmaia · Pull Request #25221 · wordpress-mobile/WordPress-iOS

iangmaia · 2026-02-04T20:29:25Z

Fixes AINFRA-1898, AINFRA-1899

Summary

Update release-toolkit gem to version 14.0
Replace deprecated ios_update_metadata_source with gp_update_metadata_source
Update metadata strings

Testing

Run bundle exec fastlane update_jetpack_appstore_strings skip_commit:true / bundle exec fastlane update_wordpress_appstore_strings skip_commit:true to test PO generation

The main change required is replacing `ios_update_metadata_source` (now deprecated) with `gp_update_metadata_source`

dangermattic · 2026-02-04T20:30:20Z

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

iangmaia · 2026-02-04T20:32:24Z

fastlane/lanes/localization.rb

+      # app_store_name: {
+      #   path: File.join(source_metadata_folder, 'name.txt'),
+      #   comment: "translators: The application name in the Apple App Store. Please keep the brand names ('Jetpack' and WordPress') verbatim. Limit to 30 characters including spaces and punctuation!"
+      # },
+      # app_store_subtitle: {
+      #   path: File.join(source_metadata_folder, 'subtitle.txt'),
+      #   comment: 'translators: Subtitle to be displayed below the application name in the Apple App Store. Limit to 30 characters including spaces and commas!'
+      # },
+      # app_store_desc: {
+      #   path: File.join(source_metadata_folder, 'description.txt'),
+      #   comment: 'translators: Multi-paragraph text used to display in the Apple App Store.'
+      # },
+      # app_store_keywords: {
+      #   path: File.join(source_metadata_folder, 'keywords.txt'),
+      #   comment: <<~COMMENT.chomp
+      #     translators: Keywords used in the App Store search engine to find the app.
+      #     Delimit with a comma between each keyword. Limit to 100 characters including spaces and commas.
+      #   COMMENT
+      # },
+      # **(1..6).to_h do |i|
+      #   [
+      #     "screenshot-text-#{i}",
+      #     { path: File.join(custom_metadata_folder, "promo_screenshot_#{i}.txt"), comment: screenshot_comment }
+      #   ]
+      # end


Given this entire part is (already was) commented out, now with the new idempotent PO generation, it removes the parts that are not present. Not sure if this is an issue to the tests the team is doing with the App Store copy? cc @crazytonyli

According to git blame this was indeed commented out due to an ongoing ASO experiment… but that was ≈3 years ago! (Oct 2023)

Also even if we end up deciding to keep it commented out for the time being, we should still (1) update this code—so that it works out of the box when we might hopefully finally uncomment it in the future—and (2) DRY the common translator comments that are common for WP vs JP in some constants to avoid repetition.

I have no idea what this ASO experiment is. Keeping or removing the comments both sounds good to me.

we should still (1) update this code—so that it works out of the box when we might hopefully finally uncomment it in the future

Oh that's what the PR initially already did.

But now I've uncommented it (121ef3b) and re-generated WordPress/Jetpack/Resources/AppStoreStrings.po.
I'm tempted to keep it like that, so that the code is again in sync with the store, the code is running again, etc.

I've checked the fields such as app_store_name, app_store_desc, app_store_subtitle, etc and everything seems to match with ASC. The <version>-whats-new matches but it was already uncommented before.
The screenshots don't seem to be generated anymore though?

(2) DRY the common translator comments

I'd say The duplication is small and each lane reads well as a self-contained unit. Maybe we could consolidate into a single lane with different parameters (like a Jetpack / WordPress configuration stored in a hash 🤔 ), but at that point that'd be a larger refactoring that we could leave for later and that could apply to a lot of lanes.

AliSoftware

LGTM, but I think we should wait for Tony (or whoever might know in the WP/JP team) to answer about the JP metadata being currently disabled before merging, as I expect/hope the conclusion will end up being that we should uncomment it and resume JP metadata sync by now before merging…

fastlane/lanes/localization.rb

AliSoftware · 2026-02-04T20:56:41Z

fastlane/lanes/localization.rb

+      # app_store_name: {
+      #   path: File.join(source_metadata_folder, 'name.txt'),
+      #   comment: "translators: The application name in the Apple App Store. Please keep the brand names ('Jetpack' and WordPress') verbatim. Limit to 30 characters including spaces and punctuation!"
+      # },
+      # app_store_subtitle: {
+      #   path: File.join(source_metadata_folder, 'subtitle.txt'),
+      #   comment: 'translators: Subtitle to be displayed below the application name in the Apple App Store. Limit to 30 characters including spaces and commas!'
+      # },
+      # app_store_desc: {
+      #   path: File.join(source_metadata_folder, 'description.txt'),
+      #   comment: 'translators: Multi-paragraph text used to display in the Apple App Store.'
+      # },
+      # app_store_keywords: {
+      #   path: File.join(source_metadata_folder, 'keywords.txt'),
+      #   comment: <<~COMMENT.chomp
+      #     translators: Keywords used in the App Store search engine to find the app.
+      #     Delimit with a comma between each keyword. Limit to 100 characters including spaces and commas.
+      #   COMMENT
+      # },
+      # **(1..6).to_h do |i|
+      #   [
+      #     "screenshot-text-#{i}",
+      #     { path: File.join(custom_metadata_folder, "promo_screenshot_#{i}.txt"), comment: screenshot_comment }
+      #   ]
+      # end


According to git blame this was indeed commented out due to an ongoing ASO experiment… but that was ≈3 years ago! (Oct 2023)

Also even if we end up deciding to keep it commented out for the time being, we should still (1) update this code—so that it works out of the box when we might hopefully finally uncomment it in the future—and (2) DRY the common translator comments that are common for WP vs JP in some constants to avoid repetition.

sonarqubecloud · 2026-02-05T15:43:19Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AliSoftware

AliSoftware · 2026-02-05T15:51:32Z

fastlane/lanes/localization.rb

-  lane :update_wordpress_appstore_strings do |options|
+  lane :update_wordpress_appstore_strings do |version: release_version_current, skip_commit: false|
    source_metadata_folder = File.join(PROJECT_ROOT_FOLDER, 'fastlane', 'metadata', 'default')
    custom_metadata_folder = File.join(PROJECT_ROOT_FOLDER, 'fastlane', 'appstoreres', 'metadata', 'source')


🎗️ Worth taking note (Linear issue?) that it would be nice to get rid of the appstoreres at some point, to remove the confusion of having 2 different sources of truth for different App Store strings, like Gio recently did in another product (can't remember which)

iangmaia added 3 commits February 4, 2026 21:17

Update release-toolkit to 14.0

83b6e8c

The main change required is replacing `ios_update_metadata_source` (now deprecated) with `gp_update_metadata_source`

Update metadata strings

f42a165

Update metadata strings

175412d

iangmaia self-assigned this Feb 4, 2026

iangmaia commented Feb 4, 2026

View reviewed changes

iangmaia requested review from AliSoftware, mokagio and twstokes February 4, 2026 20:34

iangmaia added the Tooling Build, Release, and Validation Tools label Feb 4, 2026

iangmaia added this to the 26.7 milestone Feb 4, 2026

iangmaia changed the title ~~Update release-toolkit to 14.0~~ [Tooling] Update release-toolkit to 14.0 Feb 4, 2026

iangmaia mentioned this pull request Feb 4, 2026

Bump fastlane-plugin-wpmreleasetoolkit from 13.8.1 to 14.0.0 #25172

Closed

iangmaia requested a review from crazytonyli February 4, 2026 20:35

AliSoftware reviewed Feb 4, 2026

View reviewed changes

iangmaia added 6 commits February 5, 2026 14:30

Uncomment Jetpack App Store strings generation

121ef3b

Update metadata strings

b3e8583

Update screenshot_comment appstore metadata

aeba7d7

Update metadata strings

108c917

Update metadata strings

6298552

Fix Rubocop violation

7e85eae

AliSoftware approved these changes Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tooling] Update release-toolkit to 14.0#25221

[Tooling] Update release-toolkit to 14.0#25221
iangmaia wants to merge 9 commits intotrunkfrom
iangmaia/update-release-toolkit

iangmaia commented Feb 4, 2026 •

edited

Loading

Uh oh!

dangermattic commented Feb 4, 2026 •

edited

Loading

Uh oh!

iangmaia Feb 4, 2026

Uh oh!

AliSoftware Feb 4, 2026

Uh oh!

crazytonyli Feb 4, 2026 •

edited

Loading

Uh oh!

iangmaia Feb 5, 2026

Uh oh!

AliSoftware left a comment

Uh oh!

Uh oh!

AliSoftware Feb 4, 2026

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Uh oh!

AliSoftware left a comment

Uh oh!

AliSoftware Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

iangmaia commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

dangermattic commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iangmaia Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

AliSoftware Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

crazytonyli Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iangmaia Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

AliSoftware left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AliSoftware Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed

Uh oh!

AliSoftware left a comment

Choose a reason for hiding this comment

Uh oh!

AliSoftware Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iangmaia commented Feb 4, 2026 •

edited

Loading

dangermattic commented Feb 4, 2026 •

edited

Loading

crazytonyli Feb 4, 2026 •

edited

Loading