Show options to bypass XML-RPC restrictions#25223
Merged
crazytonyli merged 2 commits intotrunkfrom Feb 10, 2026
Merged
Conversation
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
a4b3013 to
6b45ac5
Compare
6b45ac5 to
8fe3eb6
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30849 | |
| Version | PR #25223 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b40083e | |
| Installation URL | 4iut95kceba88 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30849 | |
| Version | PR #25223 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b40083e | |
| Installation URL | 4s4cop4auudso |
Contributor
|
The code looks good. I'd suggest a minor change to the visual appearance: Also the "Connect Jetpack" button probably doesn't need a subtitle. As for the second section, I'd suggest simply showing one "Learn More" and opening the XMLRPC docs. The main info view already has the explanation. With these changes, it could probably be a simpler bottom alert. |
kean
approved these changes
Feb 9, 2026
| } | ||
| .buttonStyle(.borderedProminent) | ||
| .controlSize(.small) | ||
| .controlSize(.regular) |
Contributor
There was a problem hiding this comment.
I assume it changes the button size in the Jetpack Connection screen.
Contributor
Author
|
@kean Thanks for the suggestion. The alert now looks like this:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Description
This PR address #25183 (comment).