Skip to content

Comments

Show options to bypass XML-RPC restrictions#25223

Merged
crazytonyli merged 2 commits intotrunkfrom
task/show-options-to-bypass-xmlrpc
Feb 10, 2026
Merged

Show options to bypass XML-RPC restrictions#25223
crazytonyli merged 2 commits intotrunkfrom
task/show-options-to-bypass-xmlrpc

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Feb 5, 2026

Description

This PR address #25183 (comment).

@crazytonyli crazytonyli added this to the 26.7 milestone Feb 5, 2026
@crazytonyli crazytonyli requested a review from kean February 5, 2026 02:08
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2026

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@crazytonyli crazytonyli force-pushed the task/show-options-to-bypass-xmlrpc branch from a4b3013 to 6b45ac5 Compare February 5, 2026 02:45
Base automatically changed from xmlrpc-optional to trunk February 8, 2026 20:23
@crazytonyli crazytonyli force-pushed the task/show-options-to-bypass-xmlrpc branch from 6b45ac5 to 8fe3eb6 Compare February 8, 2026 20:36
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30849
VersionPR #25223
Bundle IDcom.jetpack.alpha
Commitb40083e
Installation URL4iut95kceba88
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30849
VersionPR #25223
Bundle IDorg.wordpress.alpha
Commitb40083e
Installation URL4s4cop4auudso
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean
Copy link
Contributor

kean commented Feb 9, 2026

The code looks good.

I'd suggest a minor change to the visual appearance:

-------
(spacer)
info view
(spacer)
buttons at the bottom
-------

Also the "Connect Jetpack" button probably doesn't need a subtitle. As for the second section, I'd suggest simply showing one "Learn More" and opening the XMLRPC docs. The main info view already has the explanation. With these changes, it could probably be a simpler bottom alert.

}
.buttonStyle(.borderedProminent)
.controlSize(.small)
.controlSize(.regular)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it changes the button size in the Jetpack Connection screen.

@crazytonyli
Copy link
Contributor Author

@kean Thanks for the suggestion. The alert now looks like this:

@sonarqubecloud
Copy link

@crazytonyli crazytonyli added this pull request to the merge queue Feb 10, 2026
Merged via the queue into trunk with commit 86c389f Feb 10, 2026
24 of 29 checks passed
@crazytonyli crazytonyli deleted the task/show-options-to-bypass-xmlrpc branch February 10, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants