Merged
Conversation
4 tasks
AliSoftware
reviewed
Jun 2, 2023
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Since I'm going on vacation in a few hours, but also I think it would be nice to have someone else (cc @wordpress-mobile/apps-infrastructure), and external to the trial, to read those migration instructions to confirm if those instructions are clear enough to them — even if they haven't followed all the different PRs you made back in your branch during your trial and don't have as much context as we both do.
jkmassel
approved these changes
Jun 2, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates the
MIGRATION.mdfile with instructions on how to handle the latest breaking changes.Related PRs
MIGRATION.mdmigration guide #452 (which was created before the repo had aMIGRATION.md).Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the approprioate existing###subsection of the existing## Trunksection.