-
Notifications
You must be signed in to change notification settings - Fork 8
feat(pkce)!: consume storage-owned verifier cookie API (authkit-session 0.4.0) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nicknisi
wants to merge
3
commits into
main
Choose a base branch
from
feat/pkce-state-binding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| import { redirect, createFileRoute } from '@tanstack/react-router'; | ||
| import { getAuth, getSignInUrl } from '@workos/authkit-tanstack-react-start'; | ||
| import { getAuth } from '@workos/authkit-tanstack-react-start'; | ||
|
|
||
| export const Route = createFileRoute('/_authenticated')({ | ||
| loader: async ({ location }) => { | ||
| // Loader runs on server (even during client-side navigation via RPC) | ||
| const { user } = await getAuth(); | ||
| if (!user) { | ||
| const path = location.pathname; | ||
| const href = await getSignInUrl({ data: { returnPathname: path } }); | ||
| throw redirect({ href }); | ||
| const returnPathname = encodeURIComponent(location.pathname); | ||
| throw redirect({ href: `/api/auth/sign-in?returnPathname=${returnPathname}` }); | ||
| } | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { createFileRoute } from '@tanstack/react-router'; | ||
| import { getSignInUrl } from '@workos/authkit-tanstack-react-start'; | ||
|
|
||
| export const Route = createFileRoute('/api/auth/sign-in')({ | ||
| server: { | ||
| handlers: { | ||
| GET: async ({ request }: { request: Request }) => { | ||
| const returnPathname = new URL(request.url).searchParams.get('returnPathname'); | ||
| const url = await getSignInUrl(returnPathname ? { data: { returnPathname } } : undefined); | ||
| return new Response(null, { | ||
| status: 307, | ||
| headers: { Location: url }, | ||
| }); | ||
| }, | ||
| }, | ||
| }, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link:override must be removed before mergingThe
pnpm.overridesentry resolves@workos/authkit-sessiontolink:../authkit-session, which means any environment that only has this repo checked out (including most CI systems and every downstream contributor) will get a hard install failure —../authkit-sessionwon't exist. Thepackage.jsondependenciesfield correctly specifies"0.4.0", but pnpm still resolves through the override before publishing. This entire block must be removed (or reverted to a registry version) before the PR lands onmain.