Skip to content

perf(prover): run the first sumcheck round in the base field #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BornPsych wants to merge 5 commits into
base: feat/base-field-witness-commit
Choose a base branch
from
Draft

perf(prover): run the first sumcheck round in the base field #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67aa139
test(fixtures): add prover profiling probes (ignored)
shreyas-londhe Jul 1, 2026
92c7133
style: wrap two doc comments to 100 columns
shreyas-londhe Jul 1, 2026
0b498af
feat(common): mixed sumcheck round helpers for base-field mles
shreyas-londhe Jul 2, 2026
3097cab
perf(prover): run the first sumcheck round in the base field
shreyas-londhe Jul 2, 2026
0b6de00
refactor: address review on the base-field first sumcheck round
BornPsych Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ chrono = "0.4.41"
# This is a workaround because different package selection based on target does not mix well with workspace dependencies.
divan = "0.1.21"
hex = "0.4.3"
inferno = { version = "0.12", default-features = false }
itertools = "0.14.0"
num-bigint = "0.4"
paste = "1.0.15"
Expand Down Expand Up @@ -153,6 +154,7 @@ tokio-util = "0.7.13"
tower = "0.5.2"
tower-http = { version = "0.6.6", features = ["cors", "timeout", "trace"] }
tracing = "0.1.41"
tracing-flame = "0.2"
tracing-subscriber = { version = "0.3.18", features = ["env-filter", "ansi"] }
tracing-tracy = "=0.11.4"
tracy-client = "=0.18.0"
Expand Down
8 changes: 3 additions & 5 deletions provekit/backend/bn254/src/mavros_prove.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use {
},
provekit_prover::{prove_from_alphas, run_zk_sumcheck_prover, WhirR1CSCommitment},
tracing::instrument,
whir::transcript::ProverState,
whir::{algebra::embedding::Identity, transcript::ProverState},
};

pub trait MavrosR1CSProver {
Expand Down Expand Up @@ -53,13 +53,11 @@ impl MavrosR1CSProver for WhirR1CSScheme<Bn254Field> {
.as_ref()
.ok_or_else(|| anyhow::anyhow!("c1 must carry blinding state"))?;

let [a, b, c] = [witgen.out_a, witgen.out_b, witgen.out_c];
// `g` is committed separately in the extension field; open `blinding_eval`
// against the blinding vector (g flattened at offset 0).
let (alpha, blinding_eval) = run_zk_sumcheck_prover(
a,
b,
c,
&Identity::new(),
[witgen.out_a, witgen.out_b, witgen.out_c],
&mut merlin,
self.m_0,
&blinding.polynomial,
Expand Down
Loading
Loading