Use atomic tmp-then-rename writes in cache#62
Merged
Conversation
ferronn-dev
force-pushed
the
claude/atomic-cache-writes-DSx9L
branch
from
e34ba9e to
2faeb25
Compare
Write cache data to a .tmp file first, then rename() it to the final path so readers never see a partially-written file. https://claude.ai/code/session_01PauFrEKY4x3W5pDEqMtD6M
unlink() is POSIX-only; remove() is standard C and works on Windows too (including MSVC without deprecation warnings). https://claude.ai/code/session_01PauFrEKY4x3W5pDEqMtD6M
…ated-result clang-tidy flags memcpy(dst, src, strlen(src)) as potentially non-null-terminated. snprintf produces a properly terminated string and keeps the intent clear. https://claude.ai/code/session_01PauFrEKY4x3W5pDEqMtD6M
ferronn-dev
force-pushed
the
claude/atomic-cache-writes-DSx9L
branch
from
2faeb25 to
e76b235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeall()intactless.cto write cache data to a.tmpfile first, then atomicallyrename()it to the final path.tmpfile is cleaned up withremove()This ensures readers never observe a partially-written cache file.