Replace atol/atoi/sscanf with strtol/strtoul for clang-tidy compliance#63
Merged
Conversation
ferronn-dev
force-pushed
the
claude/strtol-conversions
branch
from
ff15623 to
6dc3387
Compare
ferronn-dev
changed the title
ferronn-dev
force-pushed
the
claude/strtol-conversions
branch
from
6dc3387 to
741cfb9
Compare
- Replace `atol()` with `strtol()` in `collect_header_callback` for Content-Length parsing
- Replace `sscanf("%02x", ...)` with a `char[3]` buffer + `strtoul(..., 16)` in `parse_hash`
- Replace `sscanf("|%d.%d.%d.%d|", ...)` with chained `strtol` calls in `parse_versions`
- Replace `atoi()` with `strtol()` in the `fdid` command for FDID argument parsing
All changes allow callers to detect parse failures via `endptr`, satisfying
the clang-tidy `bugprone-unchecked-string-to-number-conversion` check.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ferronn-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atol()withstrtol()incollect_header_callbackfor Content-Length parsingsscanf("%02x", ...)with achar[3]buffer +strtoul(..., 16)inparse_hashsscanf("|%d.%d.%d.%d|", ...)with chainedstrtolcalls inparse_versionsatoi()withstrtol()in thefdidcommand for FDID argument parsingAll changes allow callers to detect parse failures via
endptr, satisfying the clang-tidybugprone-unchecked-string-to-number-conversioncheck.