Store cache in XDG cache dir on Linux and LOCALAPPDATA on Windows#66
Merged
Merged
Conversation
Instead of writing to a relative cache/ directory, resolve the cache location from $XDG_CACHE_HOME/tactless (or $HOME/.cache/tactless) on POSIX systems and %LOCALAPPDATA%/tactless on Windows, creating the directory on first use. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- get_cache_dir now fails if mkdir returns anything other than EEXIST - cachedir stored in struct tactless and computed once in tactless_init - threaded through all download functions as const char *cachedir Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_cache_dir()which resolves the cache location from$XDG_CACHE_HOME/tactless(or$HOME/.cache/tactless) on POSIX and%LOCALAPPDATA%/tactlesson Windowscache/<hex>relative-path constructions indownload_from_cdn,download_from_cdn_archive, anddownload_archives_index_multiwith the platform-appropriate pathTest plan
~/.cache/tactless/(or$XDG_CACHE_HOME/tactless/if set)%LOCALAPPDATA%\tactless\🤖 Generated with Claude Code