Skip to content

Skip tests on Windows#128

Merged
swissspidy merged 4 commits intomainfrom
fix/windows-tests
Mar 30, 2026
Merged

Skip tests on Windows#128
swissspidy merged 4 commits intomainfrom
fix/windows-tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

@swissspidy swissspidy commented Mar 30, 2026

Windows compat is blocked by inmarelibero/gitignore-checker#18

@swissspidy swissspidy added this to the 3.2.2 milestone Mar 30, 2026
@swissspidy swissspidy requested a review from a team as a code owner March 30, 2026 11:25
@swissspidy swissspidy added the scope:testing Related to testing label Mar 30, 2026
Copilot AI review requested due to automatic review settings March 30, 2026 11:25
@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request skips distribution archive and distignore tests on Windows due to an upstream bug in the gitignore-checker library. The changes include adding @skip-windows tags to feature files and implementing a conditional skip in the Distignore_Filter_Iterator_Test setup. Feedback suggests using the DIRECTORY_SEPARATOR constant for a more idiomatic check for the Windows operating system in the PHP test suite.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test suite to avoid failures on Windows caused by an upstream gitignore-checker path-handling bug, keeping CI green while the dependency issue remains unresolved.

Changes:

  • Skip PHPUnit Distignore_Filter_Iterator_Test on Windows in setUp().
  • Add a Windows-skip tag to Behat feature files affected by .distignore behavior.
  • Remove the obsolete Behat @require-php-7.1 tags from the affected features.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/Distignore_Filter_Iterator_Test.php Adds Windows guard to skip unit tests impacted by upstream path parsing issues.
features/distignore.feature Adds Windows skip tag/comment for distignore-related Behat coverage.
features/dist-archive.feature Adds Windows skip tag/comment for dist-archive Behat coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit d789557 into main Mar 30, 2026
83 checks passed
@swissspidy swissspidy deleted the fix/windows-tests branch March 30, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants