Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
There was a problem hiding this comment.
Code Review
This pull request skips distribution archive and distignore tests on Windows due to an upstream bug in the gitignore-checker library. The changes include adding @skip-windows tags to feature files and implementing a conditional skip in the Distignore_Filter_Iterator_Test setup. Feedback suggests using the DIRECTORY_SEPARATOR constant for a more idiomatic check for the Windows operating system in the PHP test suite.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Updates the test suite to avoid failures on Windows caused by an upstream gitignore-checker path-handling bug, keeping CI green while the dependency issue remains unresolved.
Changes:
- Skip PHPUnit
Distignore_Filter_Iterator_Teston Windows insetUp(). - Add a Windows-skip tag to Behat feature files affected by
.distignorebehavior. - Remove the obsolete Behat
@require-php-7.1tags from the affected features.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Distignore_Filter_Iterator_Test.php | Adds Windows guard to skip unit tests impacted by upstream path parsing issues. |
| features/distignore.feature | Adds Windows skip tag/comment for distignore-related Behat coverage. |
| features/dist-archive.feature | Adds Windows skip tag/comment for dist-archive Behat coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Windows compat is blocked by inmarelibero/gitignore-checker#18