Remove default available translation for plugins and themes#154
Draft
dottxado wants to merge 6 commits intowp-cli:mainfrom
Draft
Remove default available translation for plugins and themes#154dottxado wants to merge 6 commits intowp-cli:mainfrom
dottxado wants to merge 6 commits intowp-cli:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-actions
bot
added
command:language-plugin
command:language-theme
scope:testing
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
en_UStranslations may not be always installed in the case of plugins and themes, so I removed the line of code that assumes the availability of the language for anything different than the core. Now the available translations are the only ones got fromwp_get_installed_translations.I needed to remove some tests because removing the assumption on the language is no more generating a good test case, and this make me think that this solution is not the best one. More in the issue discussion #84
This should fix #84
Related wp-cli/wp-cli#5955