Skip to content

make ota and deploy.sh take the server from the environment, and the style guide names no one - #381

Merged
wr merged 1 commit into
mainfrom
wells/deploy-target-env
Oct 30, 2026
Merged

wr merged 1 commit into
mainfrom
wells/deploy-target-env

Conversation

@wr

@wr wr commented Oct 30, 2026

Copy link
Copy Markdown
Owner

The public repo had one maintainer's server written into its deploy tools, and the style guide named him. This takes both out without changing what the tools do.

What changed

  • make ota, make ota-ee02: the Proxmox host and container now come from the environment instead of defaults in the Makefile. Without them the targets stop before building and say what to set:
    • FEATHERFRAME_DEPLOY_HOST: the Proxmox host, as ssh reaches it
    • FEATHERFRAME_DEPLOY_CT: the container's id
    • FEATHERFRAME_DEPLOY_DIR: the install directory in it (default /opt/featherframe)
      make help lists the targets and the two required variables; the Makefile comment explains all three.
  • scripts/deploy.sh reads the same variables, plus FEATHERFRAME_DEPLOY_PORT for the status check after the restart (default 8181, the install's default). It stops with a message naming the missing variable.
  • docs/STYLE.md: "Reports to Wells" is now "Reports to the maintainer", and the wiki's first-person pages are "in the maker's own voice". The rules are unchanged.

Verified

  • make -n ota ota-ee02 with the variables set prints the same commands as before, plus the new check.
  • bash -n scripts/deploy.sh passes. Run with ssh and scp stubbed out, it issues the same commands as before; with no variables set it stops before archiving anything.
  • make deploy-target fails with the message when the variables are unset and passes when they are set.
  • Nothing was deployed.

Left

  • The wiki's Style guide page is a copy of docs/STYLE.md and still has the old two lines.

@wr
wr merged commit c4d7d0d into main Oct 30, 2026
6 checks passed
@wr
wr deleted the wells/deploy-target-env branch October 30, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant