Repository navigation
make ota and deploy.sh take the server from the environment, and the style guide names no one - #381
Merged
Merged
Conversation
…style guide names no one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public repo had one maintainer's server written into its deploy tools, and the style guide named him. This takes both out without changing what the tools do.
What changed
make ota,make ota-ee02: the Proxmox host and container now come from the environment instead of defaults in the Makefile. Without them the targets stop before building and say what to set:FEATHERFRAME_DEPLOY_HOST: the Proxmox host, as ssh reaches itFEATHERFRAME_DEPLOY_CT: the container's idFEATHERFRAME_DEPLOY_DIR: the install directory in it (default/opt/featherframe)make helplists the targets and the two required variables; the Makefile comment explains all three.scripts/deploy.shreads the same variables, plusFEATHERFRAME_DEPLOY_PORTfor the status check after the restart (default 8181, the install's default). It stops with a message naming the missing variable.docs/STYLE.md: "Reports to Wells" is now "Reports to the maintainer", and the wiki's first-person pages are "in the maker's own voice". The rules are unchanged.Verified
make -n ota ota-ee02with the variables set prints the same commands as before, plus the new check.bash -n scripts/deploy.shpasses. Run withsshandscpstubbed out, it issues the same commands as before; with no variables set it stops before archiving anything.make deploy-targetfails with the message when the variables are unset and passes when they are set.Left
docs/STYLE.mdand still has the old two lines.