feat(stellar): preflight network checks before deploy#80
Open
gloriaelishahabu wants to merge 2 commits into
Open
feat(stellar): preflight network checks before deploy#80gloriaelishahabu wants to merge 2 commits into
gloriaelishahabu wants to merge 2 commits into
Conversation
This script performs preflight validation for a Soroban deployment network, checking network passphrase, RPC URL reachability, friendbot availability, identity existence, and required environment variables.
Added network preflight checks section to README.
|
@gloriaelishahabu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone preflight validation script for Soroban network deployments and
hooks it into
deploy.shas the first step, per #63.Currently
deploy.shacceptstestnet|futurenet|mainnetbut never validates thatthe network is actually usable before starting a deploy — a bad RPC URL, an
unreachable friendbot, or a missing identity only surfaces mid-deploy with a
confusing error. This adds a fast-failing check up front.
Closes #63
Changes
stellar/scripts/check-network.sh— new standalone script, callableindependently or as a preflight step. For the given network it verifies:
getHealthcallPrints a summary table of each check and exits non-zero if any check fails,
with a clear error message per failure.
stellar/deploy.sh— now callscheck-network.sh "$NETWORK"as the veryfirst step and aborts before doing any work if preflight fails.
.github/workflows/check-network-test.yml— CI test that runs the scriptagainst an invalid network name (expects non-zero exit) and against
testnet(expects it to run and print the summary table).
stellar/README.md— documents the new script and usage.How to test
Notes / follow-ups
these to a shared config file if the maintainers prefer a single source of
truth with
deploy.sh.stellar keys address <name>; let me know if the projecthas a different convention for resolving the deploying identity.