Add docs snippet validation gate#47
Open
bfernando wants to merge 1 commit into
Open
Conversation
|
@bfernando Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merge is clean. The snippet validator + testnet variant + CI workflow + CONTRIBUTING update all look good. One blocker: drop rm package-lock.json
git add -u
git commit --amend
git push --force-with-leaseAfter that I will merge. |
Contributor
|
Test-merges cleanly otherwise. The 2184-line rm package-lock.json
git add -u
git commit --amend --no-edit
git push --force-with-leaseSnippet validators + CI wiring + CONTRIBUTING update all look good once the lockfile is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsc --noEmitdevelop/mainno-checkopt-out indocs/CONTRIBUTING.mdno-checkNotes
The first CI gate is intentionally syntax-focused because the current docs contain many illustrative fragments and API-shape examples that are not standalone programs. The Stellar job is non-blocking because it depends on live testnet/network availability.
Validation
npm testnpm run check:stellar-testnetnpx tsc --noEmitFixes #27