feat(provider): resolve first-party OPY providers - #248
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
Major — crates/wright-driver/src/opy_provider.rs::target_for
The resolver hard-codes Windows as unsupported, but Wright currently ships x86_64-pc-windows-msvc, while #240/#244 require first-party provider resolution for supported Wright targets. The new test also locks this mismatch in by asserting Windows is unsupported, so CI cannot catch the product-contract regression.
Support the Windows release target (including its executable/archive handling) or change the approved supported-target contract before merging.
Teakowa
left a comment
There was a problem hiding this comment.
Major — crates/wright-driver/src/opy_provider.rs::OpyProviderResolver::target
Windows is still rejected before the new ZIP/.exe path can run: target_for("windows", "x86_64") now returns x86_64-pc-windows-msvc, but target() still only accepts the three Linux/macOS triples. The new Windows test calls install_archive directly, so it bypasses this resolver gate and CI remains green.
Add x86_64-pc-windows-msvc to the resolver's supported targets and cover Windows through resolve/update, not only direct archive installation.
Summary
wright provider update opyand--opy-provider, and pass the resolved executable through the existingProviderRegistry.Validation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targets --all-features </dev/nullScope note
wright#243,language-provider-protocol#16, andopy-rs#170are still open. This PR delivers the #244 resolver/bootstrap and existing LPP handoff; the full normal OPY workflow cutover remains coordinated with those dependencies.Refs #244