Skip to content

fix(worktrees): record successful setup for issue review handoffs - #603

Merged
thewrz merged 1 commit into
mainfrom
feat/issue-600
Sep 5, 2026
Merged

fix(worktrees): record successful setup for issue review handoffs#603
thewrz merged 1 commit into
mainfrom
feat/issue-600

Conversation

@thewrz

@thewrz thewrz commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

This was written agentically; verify its assertions:

Why

Worktrees prepared by parallel-issues did not record successful declared setup. A later review handoff could therefore fail when a convenience setup rerun failed.

What

Record setup success in the shared helper used by both worktree producers and remove the duplicate producer-specific write. Preserve absent-setup semantics and marker validation, with exclusive marker creation.

Decisions

Keep failed first setup fatal; tolerate a failed convenience rerun only when prior setup success is recorded. Regression coverage exercises the complete issue-to-review handoff and unsafe marker shapes.
base=origin/main
files=4
total.insertions=71
total.deletions=12
total.lines=83
operational.files=4
operational.insertions=71
operational.deletions=12
operational.lines=83
generated.files=0
generated.insertions=0
generated.deletions=0
generated.lines=0
lockfile.files=0
lockfile.insertions=0
lockfile.deletions=0
lockfile.lines=0
fixture.files=0
fixture.insertions=0
fixture.deletions=0
fixture.lines=0
non_operational.files=0
non_operational.insertions=0
non_operational.deletions=0
non_operational.lines=0

Testing

  • Regression red: five expected failures before implementation.
  • agent-run.sh --cmd test --only worktree-setup,create-issue-worktree: 146 assertions passed.
  • agent-run.sh --cmd test: 107 suites, shellcheck and repository checks passed (ALL GREEN).

🤖 Co-authored by Codex GPT-6 Astra.

Closes #600

Record successful declared setup in the shared helper so issue worktrees can tolerate a failed convenience rerun during PR review. Preserve no-setup and never-succeeded failure behavior and validate marker shapes.

Co-Authored-By: Codex gpt-6-astra <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0320b7bf-015e-4380-8ae8-a4ecb523b918

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@thewrz

thewrz commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Adversarial review receipt

  • Reviewer: provider=anthropic; model=claude-fable-5-1; effort=high; mode=cross-provider (reason: Explicit invocation override; Fable 5.1 high)
  • Counts: P1=0; P2=0; total=0
  • Reviewed head: 70ce956
  • Diff payload: wrzonance/agent-kit:603:f9eb987bedf452b6950ab602d1a10c948244b87dc1b1db243c2bbe636a83ad61
  • Confirmed finding: none confirmed

🤖 Co-authored by Codex GPT-6.

@thewrz

thewrz commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Review ledger

Machine-readable record of every review already performed on this PR.

{
  "version": 1,
  "pr": 603,
  "repo": "wrzonance/agent-kit",
  "reviews": [
    {
      "kind": "adversarial",
      "provider": "anthropic",
      "model": "claude-fable-5-1",
      "effort": "high",
      "mode": "cross-provider",
      "harness": "codex",
      "head_sha": "70ce956308d871d8ee5fef53857515329206214b",
      "covered_heads": [
        "70ce956308d871d8ee5fef53857515329206214b"
      ],
      "diff_payload": "wrzonance/agent-kit:603:f9eb987bedf452b6950ab602d1a10c948244b87dc1b1db243c2bbe636a83ad61",
      "counts": {
        "p1": 0,
        "p2": 0
      },
      "reviewed_at": "2026-09-05T05:27:33Z"
    }
  ]
}

🤖 Co-authored by Codex GPT-6.

@thewrz
thewrz marked this pull request as ready for review September 5, 2026 05:52
@thewrz
thewrz merged commit f089cda into main Sep 5, 2026
4 checks passed
@thewrz
thewrz deleted the feat/issue-600 branch September 5, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(parallel-issues): record the setup-succeeded marker so the review handoff is not fatal

1 participant