Repository navigation
fix(rootfs): emulation-test flaked on a broken pipe from qemu -version - #534
Merged
Merged
Conversation
…u -version docker run ... -version | head -1 closed the pipe while the docker CLI was still writing the second line; under pipefail that failed some runs and passed others (seen on the arm64 job of #532). Capture the output first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arm64 rootfs job failed on #532 with
write /dev/stdout: broken piperight after printing the qemu version, and passed on the previous head with identical engine content.docker run ... -version | head -1letsheadclose the pipe while the docker CLI is still writing; withset -o pipefailthat is a failure on some runs only. Capture the output, then take the first line. It is the onlydocker ... | headin guest/rootfs.