Repository navigation
docs: fix the README release and license badges - #544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's release and license badges render as
invalidon github.com.release: invalidandlicense: invalid.include_prereleases&sort=semver. Once the cache cleared it would showrelease: rootfs-v29.9.0-2, because the engine rootfs releases (29.x) sort above the app versions (0.x).Changes
filter=v*&sort=semver, so only app tags count, andinclude_prereleasesis dropped. It rendersrelease: v0.10.0. The URL change also skips the bad cache entry.badge/license-Apache--2.0). The license never changes, so it doesn't need a GitHub API call that can fail. It renderslicense: Apache-2.0.Both new URLs were fetched from shields.io and render as stated. That GitHub shows them correctly can only be seen after merge; I'll check the rendered README then.