Fixed windows-specific problem in subprocess_repl.read_bytes()#307
Open
simonzack wants to merge 10 commits intowuub:mergesfrom
Open
Fixed windows-specific problem in subprocess_repl.read_bytes()#307simonzack wants to merge 10 commits intowuub:mergesfrom
simonzack wants to merge 10 commits intowuub:mergesfrom
Conversation
…at more than 1 byte is returned on every read, by converting the pipe to an asynchronous one
…il there are bytes to be read
Owner
|
@simonzack thanks :) Are you using Sublime Text 2 or 3? Did you test both and are all repls working as before? |
Contributor
Author
|
I think it should work fine after the new commits. |
Contributor
Author
|
Any updates on this? Thanks. |
Collaborator
|
Please solve the conflicts in repl.js, since I lack the knowledge to do so, and then we'll merge this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed windows-specific problem in subprocess_repl.read_bytes(), so that more than 1 byte is returned on every read, by converting the pipe to an asynchronous one.
This issue comes up as a bug at some places, for example open an ipython repl prompt, then enter some non-existent variable name to generate an error. Then the color escape sequences are not stripped even when the option is set to True in SublimeREPL, as the color stripping function only has a single byte as input instead of all the output bytes.
This fixes the aforementioned problem.