Reject all-zero rasters in mesh_utils.create_triangulation (#1378)#1381
Merged
brendancol merged 1 commit intomainfrom Apr 30, 2026
Merged
Reject all-zero rasters in mesh_utils.create_triangulation (#1378)#1381brendancol merged 1 commit intomainfrom
brendancol merged 1 commit intomainfrom
Conversation
create_triangulation() computed scale = max(H, W) / cupy.amax(raster.data) without checking that the max was positive and finite. An all-zero raster gave scale = inf and an all-NaN raster gave scale = nan, both of which propagated into vertex z-coordinates and produced garbage geometry that the OptiX raytracer would silently render. Add a guard that raises ValueError when maxH is non-finite or non-positive, before any hash or device-buffer work. This is the deferred Cat 3 finding from the gpu_rtx security audit (#1308 / PR #1310). Tests cover the all-zero, all-NaN, all-negative, and single-positive-pixel cases plus the error-message format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_triangulation()against the divide-by-zero / divide-by-NaN that produced garbage mesh geometry on all-zero or all-NaN cupy rastersValueErrorwith the offending max value in the messageFixes #1378. Deferred Cat 3 finding from the gpu_rtx security audit (#1308 / PR #1310).
Why ValueError instead of a sentinel scale
A raster with no positive elevation has no terrain to triangulate. Substituting
scale = 1.0would still hand the OptiX raytracer a flat mesh and produce garbage hillshade / viewshed output. Raising matches the_validate_rasterstyle used elsewhere in xrspatial.Test plan
pytest xrspatial/tests/test_gpu_rtx_mesh.py -v-- 5 new tests passpytest xrspatial/tests/test_gpu_rtx_memory.py -v-- 9 existing tests still pass (4 RTX-gated end-to-end included)pytest xrspatial/tests/test_hillshade.py xrspatial/tests/test_viewshed.py-- 81 tests pass