Add geotiff writer test matrix (#1483)#1490
Merged
brendancol merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
Adds xrspatial/geotiff/tests/test_writer_matrix.py covering: - T-5: dtype x compression round-trip (8 dtypes x 5 codecs, stripped and tiled) - T-6: NaN vs sentinel nodata semantics (float NaN, float sentinel, uint8 sentinel) - T-7: COG output validity via rasterio (tiled, overviews, optional rio-cogeo validator); skipped if rasterio is missing - T-9: writing to a chmod 0o555 directory raises OSError/PermissionError; skipped on Windows and root T-10 (PlanarConfiguration=2 round-trip) was dropped. The writer doesn't emit planar=2 output. Only the reader supports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only coverage for geotiff write findings T-5, T-6, T-7, T-9 from a recent audit. No source changes. New file
xrspatial/geotiff/tests/test_writer_matrix.pyadds 85 tests.read_to_arrayandopen_geotiff.rio-cogeois installed, also runscog_validate. Note: xrspatial does not currently emit GDAL'sLAYOUT=COGIMAGE_STRUCTURE tag, so that specific marker is not asserted.OSError/PermissionError, restore mode infinally. Skipped on Windows and when running as root.PlanarConfiguration=2.Issue: #1483
Test plan
pytest xrspatial/geotiff/tests/test_writer_matrix.py(85 passed locally with rasterio installed)test_writer.pystill passes