Refactor case BC hooks: rename to define_BC/apply_BC and hoist BC fields to base#307
Open
kaanolgu wants to merge 9 commits into
Open
Refactor case BC hooks: rename to define_BC/apply_BC and hoist BC fields to base#307kaanolgu wants to merge 9 commits into
kaanolgu wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boundary_conditions->define_BCandpre_correction->apply_BCacross base and child cases.bc_{start,end}_{u,v,w}_{x,y}) ontobase_case_t; cases use only what they need.field_set_face_from_fieldbackend hook (CUDA + OMP) for spatially-varying face BCs.inlet_noise(3)config (replacesbc_start_u/v/wscalars).compute_outflow_paramsmoved fromapply_BCintodefine_BC; results stored onself%out_vel/self%flow_rate_diff(drops_cachedsuffix).cylinder_nmlfiles must replacebc_start_u/v/wwithinlet_noise.