Skip to content

Refactor case BC hooks: rename to define_BC/apply_BC and hoist BC fields to base#307

Open
kaanolgu wants to merge 9 commits into
mainfrom
boundary_precorrect_fix
Open

Refactor case BC hooks: rename to define_BC/apply_BC and hoist BC fields to base#307
kaanolgu wants to merge 9 commits into
mainfrom
boundary_precorrect_fix

Conversation

@kaanolgu
Copy link
Copy Markdown
Collaborator

  • Rename boundary_conditions -> define_BC and pre_correction -> apply_BC across base and child cases.
  • Hoist 12 BC field pointers (bc_{start,end}_{u,v,w}_{x,y}) onto base_case_t; cases use only what they need.
  • Add field_set_face_from_field backend hook (CUDA + OMP) for spatially-varying face BCs.
  • Channel: y-wall BCs now use persistent device fields refreshed with noise per substep, applied via the new hook.
  • Cylinder: inflow profile now built field-side using new inlet_noise(3) config (replaces bc_start_u/v/w scalars).
  • Cylinder: compute_outflow_params moved from apply_BC into define_BC; results stored on self%out_vel / self%flow_rate_diff (drops _cached suffix).
  • Behavioural note: outflow params sampled one substep earlier than before.
  • Breaking change: existing cylinder_nml files must replace bc_start_u/v/w with inlet_noise.

@kaanolgu kaanolgu requested a review from ia267 May 14, 2026 09:30
@kaanolgu kaanolgu self-assigned this May 14, 2026
@kaanolgu kaanolgu added the enhancement New feature or request label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant