Try to recover when Spotlight returns no results by searching /Applications folder#281
Merged
manuyavuz merged 4 commits intoxcpretty:masterfrom May 27, 2018
Conversation
manuyavuz
force-pushed
the
deep-search-on-empty-spotlight-result
branch
from
61ba13a to
662cfc3
Compare
KrauseFx
approved these changes
May 27, 2018
Member
KrauseFx
left a comment
KrauseFx
left a comment
There was a problem hiding this comment.
Looks great, thanks for your contribution @manuyavuz 👍
Collaborator
Author
|
@KrauseFx thanks for the invitation! @catflight thanks for your PR too! Merging. |
Collaborator
Author
|
Wrong button 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves #268 a little bit more by searching
/Applicationsfolder not only if Spotlight is disabled, but also if it returns no results.I've experienced this on CircleCI while trying to install additional simulators in my builds. In CircleCI, Spotlight was not disabled, but it simply wouldn't return any results.
Also added a simple description to Readme about the workaround.