Open
Conversation
segiddins
reviewed
Sep 16, 2020
segiddins
approved these changes
Sep 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for great library 😀
I found two issues in get_dmg regexp.
Issue
1. This does not matches upper case name.
Default downloaded xcode file name was
Xcode_${version}.xip,but this expression does not match this so the cache doesn't work properly.
Currently the cache seems to work because of right below issue, but not really
(maybe related to this PR #388..
But it has not been merged yet, so I included this change as well.)
2. without parentheses, the expression matches any xip extensions.
/^xcode_#{version}\.dmg|xip$/->/^xcode_#{version}\.dmg$/or/^xip$/-> ❌ (Any xip extension will matches this)/^xcode_#{version}\.(dmg|xip)$/->/^xcode_#{version}\.dmg$/or/^xcode_#{version}\.xip$/-> ⭕ What we are expected!