Use injected XCODE_INSTALL_CACHE_DIRvariable if exist.#403
Open
makesource wants to merge 2 commits intoxcpretty:masterfrom
Open
Use injected XCODE_INSTALL_CACHE_DIRvariable if exist.#403makesource wants to merge 2 commits intoxcpretty:masterfrom
XCODE_INSTALL_CACHE_DIRvariable if exist.#403makesource wants to merge 2 commits intoxcpretty:masterfrom
Conversation
segiddins
approved these changes
Sep 17, 2020
JonnyBeeGod
approved these changes
Dec 12, 2020
rogerluan
requested changes
Apr 22, 2021
Collaborator
rogerluan
left a comment
rogerluan
left a comment
There was a problem hiding this comment.
@makesource this small yet powerful change sounds great to me!
Could you write some documentation for this feature, to help with feature discoverability? 😊 Just some new docs in the README file will do 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for great library 😀
Issue
We can specify the downloaded xcode folder with
ENV["XCODE_INSTALL_CACHE_DIR"]But when downloading not cached Xcode version, the file stored the default directory
#{ENV['HOME']}/Library/Caches/XcodeInstall.So to work local cache properly, I have to move xip file after download job done.
Proposal
If user injected
XCODE_INSTALL_CACHE_DIRvariable, the install job executed under this path.