Skip to content

Fix searching for time stamp range that is included in the current clock times range#167

Merged
cbrnr merged 4 commits intoxdf-modules:mainfrom
agchitu:fix_clock_sync
Mar 25, 2026
Merged

Fix searching for time stamp range that is included in the current clock times range#167
cbrnr merged 4 commits intoxdf-modules:mainfrom
agchitu:fix_clock_sync

Conversation

@agchitu
Copy link
Contributor

@agchitu agchitu commented Mar 25, 2026

This should cover the case when the complete list of the remaining time stamps are in the current range as calculated by _detect_clock_resets

Fixes #166

@agchitu agchitu force-pushed the fix_clock_sync branch 2 times, most recently from dbe38c3 to 7fe5dcb Compare March 25, 2026 13:31
@cbrnr
Copy link
Contributor

cbrnr commented Mar 25, 2026

Thanks! The changes look good, you can just run ruff on the source file to fix the style issues.

@agchitu
Copy link
Contributor Author

agchitu commented Mar 25, 2026

I did run ruff, but maybe I have different configuration, since it does not give any warnings on the new code but on older code.

@agchitu
Copy link
Contributor Author

agchitu commented Mar 25, 2026

I'll add a new commit with the code reformat to see if the check passes

@sappelhoff
Copy link
Contributor

@cbrnr all done here :) should be good to go

@agchitu
Copy link
Contributor Author

agchitu commented Mar 25, 2026

@sappelhoff thanks Stefan.

@cbrnr cbrnr merged commit 5efc43a into xdf-modules:main Mar 25, 2026
6 checks passed
@cbrnr
Copy link
Contributor

cbrnr commented Mar 25, 2026

Thanks @agchitu and @sappelhoff!

@sappelhoff sappelhoff deleted the fix_clock_sync branch March 25, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The solution for _clock_sync does not work

3 participants