This repository was archived by the owner on Sep 20, 2026. It is now read-only.
Add niklasso/minisat Formula from Conan Center - #438
Closed
MeteorsLiu wants to merge 4 commits into
Closed
MeteorsLiu wants to merge 4 commits into
MeteorsLiu wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Reviewed the complete niklasso/minisat formula addition, including the CMake build/install definition, portability patches, zlib dependency and relocatable pkg-config metadata, version threshold, and installed consumer path. No actionable correctness, compatibility, or regression issues were identified.
Verification performed against the fixed PR commits:
- Built
releases/2.2.0on Linux/amd64 through LLAR withmadler/zlib@v1.3.1. - Confirmed both source patches apply and the installed consumer compiles and runs.
- Repeated the LLAR test to exercise the cache-hit consumer path.
- Confirmed
releases/2.0is rejected because no compatible formula range claims it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
niklasso/minisatFormula for the Conan 2.2.0 source tag, including its exported CMake build definition and portability patches.Closes #326
Validation
llar test --verbose ./niklasso/minisat@releases/2.2.0 --os darwin --arch arm64 --require validate326=patchzerogit apply --check --unidiff-zerofor both source patches atreleases/2.2.0.releases/2.0is rejected because no Formula range claims that incompatible source layout.