Skip to content
This repository was archived by the owner on Sep 20, 2026. It is now read-only.

Add niklasso/minisat Formula from Conan Center - #438

Closed
MeteorsLiu wants to merge 4 commits into
mainfrom
issue/326-minisat-restart
Closed

MeteorsLiu wants to merge 4 commits into
mainfrom
issue/326-minisat-restart

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

Summary

  • Add the niklasso/minisat Formula for the Conan 2.2.0 source tag, including its exported CMake build definition and portability patches.
  • Install the public headers, static library, license, and relocatable pkg-config metadata with the zlib closure.
  • Verify the Conan SAT-solver consumer against the installed artifacts, including a cache-hit run.

Closes #326

Validation

  • llar test --verbose ./niklasso/minisat@releases/2.2.0 --os darwin --arch arm64 --require validate326=patchzero
  • Repeated the same command to verify the cache-hit consumer path.
  • git apply --check --unidiff-zero for both source patches at releases/2.2.0.
  • Confirmed releases/2.0 is rejected because no Formula range claims that incompatible source layout.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete niklasso/minisat formula addition, including the CMake build/install definition, portability patches, zlib dependency and relocatable pkg-config metadata, version threshold, and installed consumer path. No actionable correctness, compatibility, or regression issues were identified.

Verification performed against the fixed PR commits:

  • Built releases/2.2.0 on Linux/amd64 through LLAR with madler/zlib@v1.3.1.
  • Confirmed both source patches apply and the installed consumer compiles and runs.
  • Repeated the LLAR test to exercise the cache-hit consumer path.
  • Confirmed releases/2.0 is rejected because no compatible formula range claims it.

View job run

@MeteorsLiu MeteorsLiu closed this Sep 14, 2026
@MeteorsLiu
MeteorsLiu deleted the issue/326-minisat-restart branch September 14, 2026 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Conan Center minisat recipe to LLAR

1 participant