Skip to content
This repository was archived by the owner on Sep 20, 2026. It is now read-only.

formula: add LAStools/LAStools - #481

Open
MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/287-laslib-luna
Open

MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/287-laslib-luna

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

Summary

  • Add an idiomatic LLAR Formula for LAStools/LAStools with fromVer v2.0.0, no dependencies, and a shared option defaulting to OFF.
  • Preserve the Conan laslib consumer contract with the upstream CMake build, installed LASlib headers/library, COPYING.txt, and relocatable laslib.pc metadata from the complete pkg-config lookup.
  • Apply the proven root-CMake source transformation needed to build only LASlib across upstream tags v2.0.0 through v2.0.5; use C++17 for the consumer because the Conan recipe requires C++17 and v2.0.5 uses std::filesystem.

Evidence and validation

  • Conan Center snapshot d034b32b3106d282c32f0a23314b5c6ba1b0fa69, selected recipe version 2.0.2, exact source tag v2.0.2, and pinned patch inspected.
  • Complete upstream tag set v2.0.0 through v2.0.5 inspected; GNU ordering is correct, so no comparator is needed.
  • LLAR main contract verified at goplus/llar commit 107a2d0ca6ed9524ccf465cf9449a8943afd1d3e.
  • Passed llar test on darwin-arm64 for v2.0.0, v2.0.1, v2.0.2, v2.0.3, v2.0.4, and v2.0.5.
  • Passed llar test for v2.0.2 with shared=ON on darwin-arm64, including the shared dylib runtime consumer.
  • Repeated v2.0.2 default test in the same isolated workspace; cache-hit onTest passed without rerunning CMake/build.

Only LAStools/LAStools module files are changed.

Closes #287

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete LAStools/LAStools formula unit, including the version-range manifest, upstream CMake transformations for v2.0.0 through v2.0.5, install layout, relocatable pkg-config metadata, static/shared link flags, platform filtering, and the consumer test. The changed behavior is internally consistent and I found no actionable correctness, compatibility, or reliability regressions.

Verification: llar test --verbose ./LAStools/LAStools --os linux --arch amd64 passed for the latest supported tag (v2.0.5), and an independent v2.0.0 install/link/run check passed with the generated metadata.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Conan Center laslib recipe to LLAR

1 participant