This repository was archived by the owner on Sep 20, 2026. It is now read-only.
formula: hunspell/hunspell - #482
Open
MeteorsLiu wants to merge 4 commits into
Open
MeteorsLiu wants to merge 4 commits into
MeteorsLiu wants to merge 4 commits into
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
|
|
||
| c := cmake.new(ctx.SourceDir, filepath.join(ctx.SourceDir, "_build"), installDir) | ||
| c.define "CMAKE_INSTALL_LIBDIR", "lib" | ||
| c.define "CONAN_hunspell_VERSION", "1.7.0" |
Contributor
There was a problem hiding this comment.
[P1] Preserve the selected Hunspell version
This Formula is selected for every tag from v1.7.0 onward, including the requested v1.7.2, but it hard-codes CONAN_hunspell_VERSION to 1.7.0. That value becomes CMake's PROJECT_VERSION, so later releases are installed with the 1.7.0 shared-library filename/version, and the pkg-config file below also reports 1.7.0; consumers and cache/package tooling therefore observe the wrong release and ABI filename. Either keep this threshold only for versions whose output is intentionally identical, or add version-specific Formula thresholds/metadata so each supported source tag retains its actual version.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277