formula: s-yata/marisa-trie - #505
MeteorsLiu wants to merge 3 commits into
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
The formula's build/install paths and the pre-CMake patch were reviewed across the declared version range. The consumer test is not compatible with the claimed v0.3.x range: those headers use std::string_view, so the current C++11 test command fails before the consumer can be linked. I verified the failure against upstream v0.3.0; the same test should use at least C++17 (which remains compatible with the older tags).
| os.writeFile(flagsFile, []byte(pkgconfig.lookup("marisa")!), 0o644)! | ||
|
|
||
| binary := filepath.join(testDir, "consumer") | ||
| exec! "c++", "-std=c++11", consumer, "-o", binary, "@"+flagsFile |
There was a problem hiding this comment.
[P1] Compile the consumer with C++17 for v0.3.x
The formula applies to v0.3.0 and newer tags, whose installed public headers declare std::string_view; compiling this consumer with -std=c++11 therefore fails with std::string_view has not been declared on those versions. As a result, the advertised v0.3.x validation and every non-cache build's onTest fail even though the library itself builds. Raise the test standard to at least C++17 (or select it by version); C++17 also accepts the v0.2.x headers.
This branch has not been deployed
1 participant
Summary
Validation
Closes #252