This repository was archived by the owner on Sep 20, 2026. It is now read-only.
feat: add macOS SDK formula placeholder - #531
Merged
Merged
Conversation
MeteorsLiu
marked this pull request as ready for review
September 10, 2026 08:26
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed the locked 6dc9e05...4deef8a change that registers joseluisq/macosx-sdks at SDK 14.5 with an intentionally empty build hook. The formula ID, version boundary, directory layout, and versions.json schema are internally consistent, and the no-op hook matches the documented externally supplied artifact design. Structural checks against the fixed commit passed; I found no reportable correctness or compatibility issue in this review target.
The PR now also contains follow-up commit 5b4d5bc, which is outside the locked review range and replaces the artifact wording with the explicit Apple license reminder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a macOS SDK formula placeholder with an explicit reminder to follow Apple's license terms.
The implementation includes:
joseluisq/macosx-sdkswith a formula starting at SDK14.5.onBuildwith an explicit prebuilt-artifact requirement because the SDK is not built from source here.onBuildon both macOS architectures.This keeps the SDK placeholder independent of the Linux formulas without adding SDK download or redistribution behavior.