build/wasm: pin one LLGo Binaryen release for Emscripten and WASI - #2652
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cpunion
force-pushed
the
codex/binaryen-toolchain
branch
from
September 23, 2026 11:08
fda1e16 to
08e58d7
Compare
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Timer runtime benchmarks
Compared with |
LLGo WebAssembly build benchmarks
WebAssembly output sizes
LLGo WebAssembly build measurements
Compared with |
This was referenced Sep 23, 2026
zhouguangyuan0718
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLGo's Emscripten and WASI post-link paths can select different Binaryen installations. CI also paired Emscripten 4.0.21 (Binaryen 125) with Binaryen 132, and upstream Binaryen 132 does not contain LLGo's reviewed DWARF/Asyncify backport or the Memory64 DWARF repair.
Install the published
xgo-dev/binaryenllgo-v132.3release for all CI host platforms. Archive SHA-256 values are pinned in the repository and checked before extraction. Export its root asEM_BINARYEN_ROOTand itswasm-optasWASMOPT, so Emscripten and the standalone WASI post-link use the same toolchain. Both required tools are checked and their versions logged. An explicitWASMOPTremains an override; a failed post-link reports the selected executable path and version. Update Wasm runtime and benchmark CI to Emscripten 6.0.8, whose expected Binaryen version is 132.Validation: the
llgo-v132.3release workflow passed all six platform build/test jobs and published seven archives. Each.sha256sidecar matches its GitHub asset digest. The macOS ARM64 archive passed a local SHA-256 check, extraction, and version checks forwasm-optandwasm-emscripten-finalize. With that release and Emscripten 6.0.8, dependent #2662 passed final-Wasm DWARF verification, Go/C++ source lookup, and Node/Wasmtime execution for J32, J64, and W32 at O0/O2. The stacked #2662 head also passed the fulldev/test_wasm_single_worker.sh test-commandsuite withllgo-v132.3. Focusedinternal/buildpost-link tests, 15 CI policy tests, workflowactionlint, andgit diff --checkpassed. Previous PR CI onllgo-v132.2passed both Wasm runtime suites, cross-compile, multi-host Binaryen setup, and Codecov patch coverage; CI will re-run on this pin update.Related: #2632, xgo-dev/binaryen#2, xgo-dev/binaryen#4, and dependent #2662.