Skip to content

fix(packages/pkg.icons): add icon Frame#80

Merged
unknownproperty merged 3 commits intomainfrom
131
Apr 14, 2026
Merged

fix(packages/pkg.icons): add icon Frame#80
unknownproperty merged 3 commits intomainfrom
131

Conversation

@avea-maria
Copy link
Copy Markdown
Contributor

fix #131
Добавила иконку Frame

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
xi-storybook Ready Ready Preview, Comment Apr 14, 2026 7:20am

Comment thread packages/pkg.icons/icons/Frame.tsx Outdated
@@ -0,0 +1,14 @@
import { Svg, IconProps } from '../Svg';

export const Frame = ({ ...props }: IconProps) => (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Название иконки должно соответствовать названию в файле фигмы – https://www.figma.com/design/AWD0gudx0RpQ6YVK1SttHt/UI-Icons?node-id=251-8815&t=ksAhiD1S8JjBGWoc-4

Comment thread packages/pkg.icons/icons/Frame.tsx Outdated

export const Frame = ({ ...props }: IconProps) => (
<Svg {...props}>
<path
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Иконки мы конвертируем в обязательном порядке из stroke в fill, https://iconly.io/tools/svg-convert-stroke-to-fill

Иначе иконки будут по-разному работать

@avea-maria
Copy link
Copy Markdown
Contributor Author

Исправила иконку и переименовала в transform

Comment thread packages/pkg.icons/icons/Transform.tsx Outdated
<Svg {...props}>
<path
stroke-linecap="round"
stroke-linejoin="round"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот этих двух атриббутов тут быть не должно, я сконвертировал и оптимизировал иконку и получилось следующее:

<svg width="24" height="24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M3.686 2.039a1.945 1.945 0 0 0-1.625 1.542c-.085.397-.085 2.441 0 2.838.086.408.237.685.536.984.316.316.597.461 1.061.549L4 8.017v7.979l-.15.023c-.609.092-.894.225-1.253.58-.522.518-.596.816-.596 2.401 0 1.584.074 1.881.596 2.403s.819.596 2.403.596c1.582 0 1.873-.073 2.403-.598.316-.314.461-.593.549-1.059L8.017 20h7.966l.065.342c.088.464.233.745.549 1.061.522.522.819.596 2.403.596 1.582 0 1.876-.074 2.401-.598.524-.525.598-.819.598-2.401 0-1.582-.073-1.876-.598-2.401-.356-.355-.64-.487-1.251-.58l-.15-.023V8.017l.342-.065c.456-.086.743-.235 1.059-.551.298-.299.454-.583.539-.982.084-.397.084-2.441-.001-2.838-.148-.7-.607-1.217-1.304-1.469-.248-.089-.294-.092-1.635-.092s-1.387.003-1.635.092a2.063 2.063 0 0 0-.853.564c-.249.276-.385.565-.464.982L15.983 4H8.017l-.065-.342c-.143-.755-.599-1.29-1.317-1.544-.241-.085-.323-.09-1.495-.099-.682-.005-1.336.006-1.454.024M6 5v1H4V4h2v1m14 0v1h-2V4h2v1m-3.952 1.342c.088.464.233.745.549 1.061.316.316.597.461 1.061.549l.342.065v7.979l-.15.023c-.609.092-.894.225-1.253.58-.316.314-.461.593-.549 1.059l-.065.342H8.017l-.065-.342c-.086-.456-.235-.743-.551-1.059-.356-.355-.64-.487-1.251-.58L6 15.996V8.017l.342-.065c.456-.086.743-.235 1.059-.551.316-.316.465-.603.551-1.059L8.017 6h7.966l.065.342M6 19v1H4v-2h2v1m14 0v1h-2v-2h2v1" fill-rule="evenodd" fill="#000"/></svg>

После мы убираем , преобразуем атрибуты внутри path в camelCase и для fill проставляем currentColor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пофиксила

@avea-maria
Copy link
Copy Markdown
Contributor Author

убрала лишние атрибуты, добавила fill="currentColor"

@unknownproperty unknownproperty merged commit 7166db5 into main Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants