Note where a catalog graduation note's cited evidence now lives - #794
Merged
Conversation
Family and Role graduation notes in catalog.yaml cite the specific real
beamlines that justified them ("graduated across Diamond i22, i03,
i11"), and those notes render verbatim onto the public docs/catalog/
pages. Every beamline named in a citation like that moved to the
private xmap/descriptors repo in the last two PRs; only 2-BM has a
descriptor in cora now. The claims are still accurate, just no longer
independently checkable from inside this repo the way they used to be.
Added one line each to catalog.yaml's header and docs/catalog/index.md's
"Source of truth" section: the evidence is real, just not reproduced
here, and checkable on demand in xmap/research (draft) and
xmap/descriptors (promoted).
Verified: mkdocs build --strict clean, catalog.yaml still parses,
apps/api/tests/unit/deployments (110 tests) green.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to the descriptor move.
catalog.yaml's Family/Role graduation notes cite specific real beamlines as evidence ("graduated across Diamond i22, i03, i11"), rendered verbatim onto the publicdocs/catalog/pages. Every beamline named in those citations moved to the privatexmap/descriptorsrepo across the last two PRs — the claims are still accurate, just no longer independently checkable from insidecora.Added one line each to
catalog.yaml's header comment anddocs/catalog/index.md's "Source of truth" section, pointing atxmap/research(draft) andxmap/descriptors(promoted) as where the underlying per-beamline evidence can be checked on demand.Test plan
catalog.yamlstill parses as YAMLmkdocs build --strict— cleanuv run pytest apps/api/tests/unit/deployments— 110 passed🤖 Generated with Claude Code