Show every Supply on the status page, quiet ones included - #795
Merged
Conversation
A BLEPS cooling-water trip on 2026-09-10 was recorded, pushed, and sat in the relay's buffer, yet was invisible to the operator watching the page. Three things hid it. The activity tail already carried the event and page.html already mapped Supply onto a lane, but that lane was presence-gated, so it was missing on every quiet day and a viewer could not tell "still watching" from "not drawn". The event carried no tier, so a trip rendered as the same faint dot as a routine registration. And the snapshot side had no Supply at all, so the default view could not answer what a run's resources are resting in. The drain deliberately does not narrow to healthy rows, which is the one place this departs from every sibling drain here. A Supply earns its place on screen precisely when it is Unavailable, Recovering, or has never been observed at all; narrowing it the way the enclosure drain narrows to Active would empty the panel on the days it matters. Only terminal Decommissioned is dropped, and in Python rather than by the query, because ListSupplies.status takes a single value and "all but one" is not expressible as a filter. Recovering is tiered notable rather than routine even though it is the good-news direction: it means a person still has to accept the supply back. Drawn quietly it goes unnoticed, which is how one rested there for a fortnight at 2-BM. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A BLEPS cooling-water trip at 2-BM on 2026-09-10 08:16 CDT was recorded, pushed, and sitting in the relay's 24h buffer, yet was invisible to the operator watching the status page. Verified by connecting to
/watchas a viewer: the event was the only activity event in the buffer, so this was never a plumbing problem.Three things hid it, all on the render side:
supplieslane was presence-gated, so it was absent on every quiet day and a viewer could not tell "still watching" from "not drawn"SupplyMarkedUnavailablecarried noEVENT_TIER, so a trip drew as the same faint dot as a routine registrationChanges
_status_push.py:_drain_suppliesplus asuppliessnapshot field, threaded through_build_payload_fields/_push_loop/status_push_lifespan, wired inmain.pypage.html: supply event tiers,suppliesadded toALWAYS_ON, and asupplyLinespanel naming each supply with status, reason and timedesign/fixtures.js: a Supplies lane so the harness stops diverging from an always-on pageseed_status_publisher.py: docstring now says ten BCs, and drops a stale claim that reads are issued asSYSTEM_PRINCIPAL_ID(all 13 call sites pass the agent principal)Two deliberate calls
The drain does not narrow to healthy rows, unlike every sibling drain here. A Supply earns its place on screen precisely when it is
Unavailable,Recovering, or never observed; narrowing it the way the enclosure drain narrows toActivewould empty the panel on the days it matters. Only terminalDecommissionedis dropped, in Python rather than by the query, becauseListSupplies.statustakes a single value.STATUS_PUBLISHER_AGENT_DESCRIPTIONis untouched even though it lists the BCs.seed_agentis create-only, so editing it would change only fresh deployments and silently diverge from arcturus's existing record.Test plan
test_lifespan_pushes_unhealthy_supplies_and_drops_only_decommissionedguards the non-obvious invariant, and is mutation-checked: narrowing the drain toAvailable(the plausible wrong implementation) makes it fail🤖 Generated with Claude Code