Repository navigation
Feat: Structural expression model - #19
Open
PauloCarvalho13 wants to merge 3 commits into
Open
PauloCarvalho13 wants to merge 3 commits into
PauloCarvalho13 wants to merge 3 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ExpressionBuilderarchitecture to support an AST-based design for building DataStar expressions.Previously, expressions were built through string concatenation, with precedence and grouping handled while generating the final JavaScript expression. This approach makes expression composition more tightly coupled to string generation and makes the implementation harder to maintain and extend.
With this refactor, expressions are represented structurally as an Abstract Syntax Tree (AST). Expression operations now build AST nodes, while JavaScript rendering is handled separately. This makes the expression-building process more modular and provides a cleaner separation between expression composition and rendering.
This architecture also makes the implementation more sustainable and extensible, allowing new expression features and operations to be introduced without requiring additional string-based composition logic.