Open
Conversation
anarcat
reviewed
Jan 24, 2022
Author
|
I forgot that inside the container it was always thinking the timezone was UTC, so I added the TIMEZONE build argument to set it how you like. |
anarcat
reviewed
Jan 24, 2022
| COPY --from=0 /src/tty-clock /usr/bin/tty-clock | ||
| CMD ['/usr/bin/tty-clock'] | ||
| RUN apk add -U ncurses-libs tzdata && \ | ||
| cp -rf /usr/share/zoneinfo/${TIMEZONE} /etc/localtime |
Collaborator
There was a problem hiding this comment.
why isn't this just a TZ environment that can be passed by the docker run caller?
Author
There was a problem hiding this comment.
ah, that works too, you can set the default for the container with the build argument, as well as override it at runtime with the environment TZ. I could remove the default, but I think its nice to be able to set it and not have to specify it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
Dockerfileand amake dockertarget to build tty-clock in an alpine container image.With the Dockerfile colocated with the source code in git, you can build the image all with one command: